Open
Conversation
66a85a7 to
c8d1794
Compare
kwin
commented
Jul 30, 2025
| * @param <T> the type of result returned by this command | ||
| */ | ||
| public interface Command { | ||
| public interface Command<T extends ScmResult> { |
Member
Author
There was a problem hiding this comment.
@olamy Is this backwards-compatible enough? It won't affect consumers as ScmProvider does not use this. I consider this a SPI only interface (so only https://github.com/olamy/maven-scm-provider-svnjava would be affected).
c8d1794 to
c349593
Compare
Strong typing of Command's response type This closes #1272
c349593 to
d6391e4
Compare
Contributor
|
can you resolve the conflicts? |
Member
Author
Only once I have someone's confirmation that this is something we can/should do in a minor version upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strong typing of Command's response type
This closes #1272
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.