Fixes #759 - Plugin generates corrupted shaded sources beyond recognition #759

[ursaj]

This PR adds support for binary operations and missing Java keywords into shade sources functionality of the maven-shade-plugin as reported in #759.

Following this checklist to help us incorporate your
contribution quickly and easily:

• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.

• You have run the integration tests successfully (mvn -Prun-its clean verify).

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• Plugin generates corrupted shaded sources beyond recognition #759

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.

• Each commit in the pull request should have a meaningful subject line and body.

• Format the pull request title like [MSHADE-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MSHADE-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.

• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.

• You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[kwin]

Thanks for the PR and sorry for the late review.

[kwin]

Why are three conditions necessary when the first and the second can never be true without the last one? Isn't the last one sufficient then? This also requires some renaming of this constant.

[kwin]

Also a comment would be much appreciated why those characters are not allowed...

[ursaj]

original regex was:

• ether dot
• or slash
• or space at the end of string

new regex matches

• either dot
• or slash
• or space at the end of string. where string does NOT end with operator (generic type, binary, trinary)

regarding comment or renaming - I don't mind. your suggestions?