NIFI-15139 Fix bootstrap diagnostics argument handling #10469
+317
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15139 Corrects argument handling for the
diagnosticscommand of the bootstrap process to support both the verbose and the output path arguments together in either order.The initial refactored bootstrap implementation worked with the output path specified, but did not handle the verbose option correctly.
The refactored approach delegates argument processing to a separate
DiagnosticsBootstrapCommandProviderand introduces a new unit test that exercises command execution, confirming the URI requested and the presence of the diagnostics output file when requested.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation