Skip to content

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-15139 Corrects argument handling for the diagnostics command of the bootstrap process to support both the verbose and the output path arguments together in either order.

The initial refactored bootstrap implementation worked with the output path specified, but did not handle the verbose option correctly.

The refactored approach delegates argument processing to a separate DiagnosticsBootstrapCommandProvider and introduces a new unit test that exercises command execution, confirming the URI requested and the presence of the diagnostics output file when requested.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Refactored diagnostics command handling to support verbose and output path arguments together
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant