-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Fix] Preserve nested JSON structure in HttpClientProvider request body #9916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EnergeticPulse
wants to merge
10
commits into
apache:dev
Choose a base branch
from
EnergeticPulse:fix-http-client-nested-json-body
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Fix] Preserve nested JSON structure in HttpClientProvider request body #9916
EnergeticPulse
wants to merge
10
commits into
apache:dev
from
EnergeticPulse:fix-http-client-nested-json-body
+73
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you enable CI following the instructions? |
…' into fix-http-client-nested-json-body
CI has been enabled, but I don't know why engine-v2-it (11, ubuntu-latest) keeps failing |
You can find the details in the CI error log |
Hisoka-X
reviewed
Oct 10, 2025
return Collections.emptyMap(); | ||
} | ||
try { | ||
return JsonUtils.parseObject(body, new TypeReference<Map<String, Object>>() {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that body is a list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Checklist
[hotfix] [docs] Fix typo in README. md doc
.Purpose of this pull request
This pull request fixes a bug in the HTTP connector where nested JSON request bodies (e.g.,
{"user": {"name": "Alice"}}
) are incorrectly flattened into dot-separated keys like{“user->name": "Alice"}
due to the use ofConfigFactory.parseString()
. This breaks compatibility with APIs that expect structured JSON payloads. The fix replacesConfigFactory
withJsonUtils. parseObject()
to preserve the original nested structure.Does this PR introduce any user-facing change?
Yes.
{"a": {"b": 1}}
→{“a->b": "1"}
).{"a": {"b": 1}}
remains a nested map).aaaaaThis change ensures the HTTP connector sends correctly structured JSON to downstream services, which is the expected behavior for most REST APIs. It is backward compatible for valid JSON inputs; invalid JSON bodies fall back to an empty map (same as before).
How was this patch tested?
HttpClientProviderTest.java
:testFixedBodyParsingPreservesNestedJsonStructure()
: verifies that nested objects, arrays, and primitives are correctly preserved after the fix.seatunnel-connector-http
still pass.Check list