Add Checkstyle pre-commit hook for Java code quality [SEDONA-2189] #2217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed directly via GitHub because local git push was blocked by previous commit errors. This change adds the Checkstyle pre-commit hook to enforce Java code style automatically.
Merge branch 'add-checkstyle-hook' into master Added Checkstyle pre-commit hook to enforce Java code style automatically.
jiayuasu
reviewed
Aug 2, 2025
|
I have reverted the shell script and Python build script license header changes from this PR to keep the scope focused solely on adding the Checkstyle pre-commit hook for Java code quality enforcement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Checkstyle pre-commit hook to enforce Java code style automatically before commits. The hook runs mvn checkstyle:check on Java files to detect style violations. Since Spotless already handles Scala formatting, no changes have been made to Scala-related hooks.
Currently, the codebase contains many legacy Checkstyle violations. This PR does not fix those violations but focuses solely on adding the enforcement mechanism to improve code quality for future commits.
How was this patch tested?
Locally tested by installing pre-commit hooks and running all hooks using pre-commit run --all-files.
Verified that the Checkstyle hook runs and fails when violations exist, demonstrating enforcement.
Confirmed all other hooks either pass or skip as expected.
Did this PR include necessary documentation updates?
No, this PR does not affect any public API and does not require documentation changes.