-
Notifications
You must be signed in to change notification settings - Fork 729
[DOCS] update homepage links #2353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Apache Sedona homepage documentation with new links and content improvements. The changes replace placeholder links with actual URLs, update installation commands, and modify the user experience examples.
- Replace SQL example with spatial query example showcasing Sedona functionality
- Update installation commands and tab ordering to prioritize PySpark
- Add functional links to documentation, GitHub repositories, and community resources
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
||
<!-- Section Get Started --> | ||
<section class="section-get-started"> | ||
<!-- <section class="section-get-started"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider removing this commented-out section entirely rather than leaving it as commented code, which can create maintenance overhead and confusion.
Copilot uses AI. Check for mistakes.
</div> | ||
</section> | ||
</section> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider removing this commented-out section entirely rather than leaving it as commented code, which can create maintenance overhead and confusion.
Copilot uses AI. Check for mistakes.
Thanks for the PR. Some comments
Please prepare the same example for (1) SedonaSpark (2) SedonaDB. Don't do any Java example or irrelevant PySpark example.
I suggest the following deployment mode SedonaSpark
SedonaSpark in Docker
SedonaDB
|
docs-overrides/main.html
Outdated
<div class="info-item__description editor">Distributed batch processing on Apache Spark clusters.</div> | ||
<div class="info-item__cta"> | ||
<a href="#" class="btn-link"> | ||
<a href="https://sedona.apache.org/latest/setup/overview/" class="btn-link"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use absolute paths, use relative path instead.
I believe it will look like "setup/overview/". Please try locally.
docs-overrides/main.html
Outdated
<div class="info-item__description editor">Real-time spatial analytics using Apache Flink.</div> | ||
<div class="info-item__cta"> | ||
<a href="#" class="btn-link"> | ||
<a href="https://sedona.apache.org/latest/setup/flink/install-scala/" class="btn-link"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. There are a few other places as well.
Please don't use absolute paths, use relative path instead.
I believe it will look like "setup/overview/". Please try locally.
Co-authored-by: Kelly-Ann Dolor <[email protected]>
change from absolute to relative paths
Did you read the Contributor Guide?
Yes, I have read the Contributor Rules and Contributor Development Guide
No, I haven't read it.
Is this PR related to a ticket?
[DOCS] my subject
What changes were proposed in this PR?
Updates the homepage with links and some tweaks.
How was this patch tested?
Tested locally with
mkdocs serve
.Did this PR include necessary documentation updates?