Skip to content

Conversation

Swastyy
Copy link
Member

@Swastyy Swastyy commented Jul 29, 2025

Fixes #35830

Changes proposed in this pull request:
-Updated write method for PostgreSQLBoolArrayBinaryProtocolValue


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@RaigorJiang
Copy link
Contributor

Hi @Swastyy , please fix CI

@Swastyy Swastyy requested a review from RaigorJiang July 30, 2025 12:44
@Swastyy
Copy link
Member Author

Swastyy commented Jul 30, 2025

Hi @Swastyy , please fix CI

Hi, I have fixed the CI. Please review it.

@RaigorJiang
Copy link
Contributor

Hi @Swastyy , Thanks for your help, I'm wondering if you've tested this write method with any PG client?

@Swastyy
Copy link
Member Author

Swastyy commented Aug 5, 2025

Hi @Swastyy , Thanks for your help, I'm wondering if you've tested this write method with any PG client?

Hi @RaigorJiang , I did run the mvn test and the tests build successfully but to test it from pgadmin I was trying to startup the proxy server but facing some issue with the server.yaml properties and I am unable to find it directly in the docs, can you help me get the configuration for server.yaml?

@ShenFeng312
Copy link

Actually, your implementation is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement write methods that are not yet supported in PostgreSQLBinaryProtocolValue

3 participants