Skip to content

Fix MySQL JDBC query properties extension when SSL is required on server #36581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
+1 −3
Merged

Fix MySQL JDBC query properties extension when SSL is required on server #36581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ache/shardingsphere/data/pipeline/mysql/datasource/MySQLJdbcQueryPropertiesExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ public final class MySQLJdbcQueryPropertiesExtension implements JdbcQueryPropert
private final Properties completeIfMissedQueryProps = new Properties();

public MySQLJdbcQueryPropertiesExtension() {
toBeOverrideQueryProps.setProperty("useSSL", Boolean.FALSE.toString());
toBeOverrideQueryProps.setProperty("useServerPrepStmts", Boolean.FALSE.toString());
toBeOverrideQueryProps.setProperty("rewriteBatchedStatements", Boolean.TRUE.toString());
toBeOverrideQueryProps.setProperty("yearIsDateType", Boolean.FALSE.toString());
Expand Down
3 changes: 1 addition & 2 deletions .../shardingsphere/data/pipeline/mysql/datasource/MySQLJdbcQueryPropertiesExtensionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ private void assertExtension(final JdbcQueryPropertiesExtension actual) {
}

private void assertQueryProperties(final Properties actual, final String expectedNetTimeoutForStreamingResults) {
assertThat(actual.size(), is(8));
assertThat(actual.getProperty("useSSL"), is(Boolean.FALSE.toString()));
assertThat(actual.size(), is(7));
assertThat(actual.getProperty("useServerPrepStmts"), is(Boolean.FALSE.toString()));
assertThat(actual.getProperty("rewriteBatchedStatements"), is(Boolean.TRUE.toString()));
assertThat(actual.getProperty("yearIsDateType"), is(Boolean.FALSE.toString()));
Expand Down