Skip to content

Refactor ITContainers #36613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

Refactor ITContainers #36613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...est/java/org/apache/shardingsphere/test/e2e/agent/engine/env/AgentE2ETestEnvironment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public void init() {
}

private void createProxyEnvironment(final DockerITContainer agentPluginContainer) {
containers = new ITContainers();
containers = new ITContainers(null);
ShardingSphereProxyClusterContainer proxyContainer = new ShardingSphereProxyClusterContainer(databaseType, getAdaptorContainerConfiguration());
proxyContainer.withLogConsumer(testConfig.isLogEnabled() ? this::collectLogs : null);
StorageContainer storageContainer = StorageContainerFactory.newInstance(
Expand Down Expand Up @@ -148,7 +148,7 @@ private AdaptorContainerConfiguration getAdaptorContainerConfiguration() {
}

private void createJDBCEnvironment(final DockerITContainer agentPluginContainer) {
containers = new ITContainers();
containers = new ITContainers(null);
StorageContainer storageContainer = StorageContainerFactory.newInstance(
databaseType, imageConfig.getMysqlImage(), DatabaseTypedSPILoader.getService(StorageContainerConfigurationOption.class, databaseType), null);
ShardingSphereJdbcAgentContainer jdbcAgentContainer = new ShardingSphereJdbcAgentContainer(
Expand Down
4 changes: 0 additions & 4 deletions ...v/src/test/java/org/apache/shardingsphere/test/e2e/env/container/atomic/ITContainers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ public final class ITContainers implements Startable {

private volatile boolean started;

public ITContainers() {
scenario = null;
}

/**
* Register container.
*
Expand Down