Skip to content

Views will not be persisted when federation not enabled #36762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2025
Merged

Views will not be persisted when federation not enabled #36762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8830628
Views will not be persisted when federation not enabled
menghaoranss Sep 30, 2025
5c7e188
Merge remote-tracking branch 'origin/master' into dev
menghaoranss Oct 9, 2025
aa46ed1
Refactor DALE2EIT
menghaoranss Oct 9, 2025
a52ddae
Fix checkstyle for DALE2EIT
menghaoranss Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions ...sphere/mode/metadata/refresher/pushdown/type/view/AlterViewPushDownMetaDataRefresher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,29 +50,22 @@ public void refresh(final MetaDataManagerPersistService metaDataManagerPersistSe
final String schemaName, final DatabaseType databaseType, final AlterViewStatement sqlStatement, final ConfigurationProperties props) throws SQLException {
String viewName = TableRefreshUtils.getTableName(sqlStatement.getView().getTableName().getIdentifier(), databaseType);
Collection<ShardingSphereTable> alteredTables = new LinkedList<>();
Collection<ShardingSphereView> alteredViews = new LinkedList<>();
Collection<String> droppedTables = new LinkedList<>();
Collection<String> droppedViews = new LinkedList<>();
Optional<SimpleTableSegment> renameView = sqlStatement.getRenameView();
if (renameView.isPresent()) {
String renameViewName = renameView.get().getTableName().getIdentifier().getValue();
String originalView = database.getSchema(schemaName).getView(viewName).getViewDefinition();
ShardingSphereSchema schema = getSchema(database, logicDataSourceName, schemaName, renameViewName, originalView, props);
alteredTables.add(schema.getTable(renameViewName));
alteredViews.add(schema.getView(renameViewName));
droppedTables.add(viewName);
droppedViews.add(viewName);
}
Optional<String> viewDefinition = sqlStatement.getViewDefinition();
if (viewDefinition.isPresent()) {
ShardingSphereSchema schema = getSchema(database, logicDataSourceName, schemaName, viewName, viewDefinition.get(), props);
alteredTables.add(schema.getTable(viewName));
alteredViews.add(schema.getView(viewName));
}
metaDataManagerPersistService.alterTables(database, schemaName, alteredTables);
metaDataManagerPersistService.alterViews(database, schemaName, alteredViews);
metaDataManagerPersistService.dropTables(database, schemaName, droppedTables);
metaDataManagerPersistService.dropViews(database, schemaName, droppedViews);
}

private ShardingSphereSchema getSchema(final ShardingSphereDatabase database, final String logicDataSourceName,
Expand Down
2 changes: 0 additions & 2 deletions ...phere/mode/metadata/refresher/pushdown/type/view/CreateViewPushDownMetaDataRefresher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import org.apache.shardingsphere.infra.metadata.database.schema.builder.GenericSchemaBuilderMaterial;
import org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereSchema;
import org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereTable;
import org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereView;
import org.apache.shardingsphere.infra.rule.attribute.datanode.MutableDataNodeRuleAttribute;
import org.apache.shardingsphere.mode.metadata.refresher.pushdown.PushDownMetaDataRefresher;
import org.apache.shardingsphere.mode.metadata.refresher.util.TableRefreshUtils;
Expand Down Expand Up @@ -57,7 +56,6 @@ public void refresh(final MetaDataManagerPersistService metaDataManagerPersistSe
Optional<ShardingSphereTable> actualTableMetaData = Optional.ofNullable(schemas.get(schemaName)).map(optional -> optional.getTable(viewName));
Preconditions.checkState(actualTableMetaData.isPresent(), "Load actual view metadata '%s' failed.", viewName);
metaDataManagerPersistService.alterTables(database, schemaName, Collections.singleton(actualTableMetaData.get()));
metaDataManagerPersistService.alterViews(database, schemaName, Collections.singleton(new ShardingSphereView(viewName, sqlStatement.getViewDefinition())));
}

@Override
Expand Down
3 changes: 3 additions & 0 deletions test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dal/DALE2EIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ private void assertExecute(final SQLE2EITContext context) throws SQLException {
try (Connection connection = environmentEngine.getTargetDataSource().getConnection()) {
try (Statement statement = connection.createStatement()) {
statement.execute(context.getSQL());
Thread.sleep(1000L);
assertExecuteResult(context, statement);
} catch (final InterruptedException ignore) {
Thread.currentThread().interrupt();
}
}
}
Expand Down