Add more test cases on DataNodeUtilsTest #36943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…method - Add 10 new test cases to achieve 100% code coverage - Test normal cases, cycling behavior, edge cases, and exception scenarios - Cover all code branches including iterator reset logic - Ensure clean test code with no duplication - Verify exact string formatting and ordering behavior Test cases added: - assertGetFormattedDataNodes: Basic functionality with amount < dataSources - assertGetFormatSingleDataNode: Single data source cycling behavior - assertGetFormattedDataNodesWithCycling: Iterator reset when amount > dataSources - assertGetFormattedDataNodesWithZeroAmount: Edge case with zero amount - assertGetFormattedDataNodesWithAmountEqualToDataSourcesSize: Exact match scenario - assertGetFormattedDataNodesWithSpecialCharactersInLogicTable: Special character handling - assertGetFormattedDataNodesWithLargeAmount: Performance testing with large datasets - assertGetFormattedDataNodesWithEmptyDataSources: Exception handling for empty collections - assertGetFormattedDataNodesWithSingleAmountAndMultipleDataSources: Minimal amount scenario - assertGetFormattedDataNodesIteratorResetBehavior: Complex iterator reset verification 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
taojintianxia
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.