preload driver in connection pool #183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not have mixed connections (multiple driver instances when fallbacking on TCCL)
| } | ||
| if (connection==null) { | ||
| throw new SQLException("Driver:"+driver+" returned null for URL:"+driverURL); | ||
| throw new SQLException("Driver:"+parent.getDriver()+" returned null for URL:"+driverURL); |
There was a problem hiding this comment.
throw new SQLException("Driver:" + parent.getDriver() + " returned null for URL:" + driverURL);
There was a problem hiding this comment.
this is not the global style so think it would be unlikely to be better with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
share it for all connections to not have mixed connections (multiple driver instances when fallbacking on TCCL)
Side note: the setters of DataSource(Proxy) should likely recreate the pool when called, not sure it is not already the case but looks fishy so a follow up issue can be needed