fix(lint): Suppress latest clang-tidy warnings

[junrushao]

Introduced by #286, where CaptureTuple, i.e. CaptureTupleAux<PackedArgs>::type, is defined as:

std::tuple<std::optional<std::decay_t<Args>>...>

and star access to its std::optional is indeed unchecked but intended.

[gemini-code-assist]

Summary of Changes

Hello @junrushao, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a recently introduced clang-tidy warning by explicitly suppressing bugprone-unchecked-optional-access in a specific code path. The warning pertains to an std::optional access that is designed to be unchecked, ensuring that the build remains clean without altering the intended runtime behavior of the CaptureTuple mechanism.

Highlights

• Clang-Tidy Warning Suppression: A new clang-tidy warning, bugprone-unchecked-optional-access, is being suppressed in include/tvm/ffi/reflection/overload.h.
• Intended Unchecked Access: The suppression targets an intentional unchecked access to std::optional within the CaptureTuple type, as described in the PR body, which was introduced by PR [Feature] Support dynamic-style overload for FFI object types #286.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly suppresses a clang-tidy warning (bugprone-unchecked-optional-access). The unchecked access to the std::optional value is safe in this context, as the calling function TryCall ensures through TrySetAux that all optionals in the tuple have a value before CallAux is invoked. This is a good cleanup to reduce static analysis noise. I've also included a suggestion to use std::forward for more idiomatic C++, which simplifies the argument forwarding logic.

[gemini-code-assist]

The argument forwarding logic can be simplified and made more idiomatic by using std::forward. It achieves the same goal of correctly forwarding the value category of the arguments to the wrapped function f_ but is more concise and recognizable as a forwarding pattern.

    // NOLINTNEXTLINE(bugprone-unchecked-optional-access)
    return f_(std::forward<std::tuple_element_t<I, PackedArgs>>(*std::get<I>(tuple))...);

[Ubospica]

LGTM!