Skip to content

fix(spark): Correct shuffle read time metrics#2736

Merged
zuston merged 1 commit intoapache:masterfrom
wForget:minor_fix
Mar 5, 2026
Merged

fix(spark): Correct shuffle read time metrics#2736
zuston merged 1 commit intoapache:masterfrom
wForget:minor_fix

Conversation

@wForget
Copy link
Member

@wForget wForget commented Mar 5, 2026

What changes were proposed in this pull request?

Correct shuffle read time metrics

Why are the changes needed?

The metrics for shuffle read time are mismatched.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Needn't

@@ -424,8 +424,8 @@ public ShuffleReadTimes getShuffleReadTimes() {

return new ShuffleReadTimes(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShuffleReadTimes constructor:

public ShuffleReadTimes(
long fetch, long crc, long copy, long backgroundDecompress, long backgroundFetch) {

@wForget
Copy link
Member Author

wForget commented Mar 5, 2026

cc @zuston

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Test Results

  750 files  ±0    750 suites  ±0   4h 37m 3s ⏱️ - 2m 49s
  228 tests ±0    227 ✅ ±0   1 💤 ±0  0 ❌ ±0 
2 750 runs  ±0  2 735 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 03b377f. ± Comparison against base commit b324cc3.

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@zuston zuston merged commit 2963220 into apache:master Mar 5, 2026
26 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants