[#2740] improvement(server) Just check block count while checking commit result#2742
Open
xianjingfeng wants to merge 1 commit intoapache:masterfrom
Open
[#2740] improvement(server) Just check block count while checking commit result#2742xianjingfeng wants to merge 1 commit intoapache:masterfrom
xianjingfeng wants to merge 1 commit intoapache:masterfrom
Conversation
Test Results 3 162 files + 7 3 162 suites +7 6h 50m 7s ⏱️ -34s For more details on these failures, see this check. Results for commit 34a8fd9. ± Comparison against base commit b98b488. |
Contributor
|
Count may not be correct if we have the duplicated data or the duplicated commit operation. |
xianjingfeng
commented
Mar 20, 2026
| shuffleTaskInfos.computeIfAbsent(appId, x -> new ShuffleTaskInfo(appId)); | ||
| long size = 0L; | ||
| // With memory storage type should never need cachedBlockIds, | ||
| int blockCount = spbs.length - shufflePartitionedData.getDuplicateBlockCount(); |
Member
Author
There was a problem hiding this comment.
Duplicated blocks will not be countd. @roryqi
Furthermore, based on the current code, the same block will not be committed twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace Roaring64NavigableMap with AtomicLong for checking commit result
Why are the changes needed?
Fix: #2740
To save memory.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI