Draft
Conversation
Contributor
|
Looks good, but is it ready to be merged w.r.t the azure-nibble validator? |
Member
Author
Yes, the functions are all written, and it works. However it propapbly needs some more error handling! |
Paalar
approved these changes
Apr 19, 2021
Contributor
Paalar
left a comment
Paalar
left a comment
There was a problem hiding this comment.
Just one small comment, else it looks good!
| process.env.REACT_APP_CLIENT_SECRET || "" | ||
| ); | ||
| export const LOGIN_URL = (code: string, rfid: string): string => | ||
| `https://nibble4-validator.azurewebsites.net/api/login?code=${code}&&rfid=${rfid}`; |
Contributor
There was a problem hiding this comment.
Should make https://nibble4-validator.azurewebsites.net/api/ into a base variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the api calls so that it retrives a key from localstorage to make API-calls to azure functions. This will make it possible to host nibble4 in a secure manner.
The key need to be stored as AZURE_DEFAULT_KEY in the applications localstorage. The key can be found in the azure functions app.