Add io_uring support to System #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for some reason, the linker on my linux machine fails to link the tests otherwise. investigate / fix before merging.
Catfish-Man
commented
Oct 29, 2024
Catfish-Man
commented
Oct 31, 2024
toffaletti
reviewed
Jan 19, 2025
Catfish-Man
changed the title
Member
Author
|
How concerned should I be about "error: unknown attribute 'unsafe'"? That just seems like a too-old compiler? |
|
The code does still have to compile in the older versions, so you should be able to protect against this by using |
…ow stopped compiling overnight
…into david/ioring
…not compiling, since we don't have Linux version checks at compile time
jrflat
reviewed
Jul 11, 2025
Contributor
jrflat
left a comment
jrflat
left a comment
There was a problem hiding this comment.
Left a few questions but I think it overall looks good! Small nit but maybe we could group the new source files in an IORing folder?
…dows build with older compilers
…into david/ioring
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test |
jrflat
approved these changes
Jul 11, 2025
Contributor
jrflat
left a comment
jrflat
left a comment
There was a problem hiding this comment.
Nice work chasing down those issues! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.