store origin navState instead of G4TouchableHandle in HostTrackData#487
Open
SeverinDiederichs wants to merge 1 commit intoapt-sim:masterfrom
Open
Conversation
|
Can one of the admins verify this patch? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the origin Touchable handling in the HostTrackData Mapper.
Before, there was a
!missing in this if-Statement:Thus, the originTouchableHandle was never set. Fixing it, a major run time regression was found.
Indeed creating
G4TouchableHandleis very expensive.Therefore, now the
vecgeom::NavStateis stored in the hostTrackData and theG4TouchableHandleis only created when the track is returned to G4 from the GPU and not already per step.This mitigates the impact significantly. In the extreme case of testEm3 where each second layer is a GPU region, the overhead was drastically reduced, in normal cases it was fully mitigated.
As the origin Touchable so far is only needed by ATLAS, one might see if it should be guarded as a compile time option.
It was verified that this PR