fix missing UI command, add CI test to test all UI commands#489
Open
SeverinDiederichs wants to merge 1 commit intoapt-sim:masterfrom
Open
fix missing UI command, add CI test to test all UI commands#489SeverinDiederichs wants to merge 1 commit intoapt-sim:masterfrom
SeverinDiederichs wants to merge 1 commit intoapt-sim:masterfrom
Conversation
SeverinDiederichs
added
CI
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings back the UI command
/adept/setHitBufferSafetyFactorwhich was accidentally deleted in #479. This is an important but rarely used parameter in special cases when running out of hit slots.A CI test is introduced that tests all UI commands (apart from reading a B field from file), to make sure all current commands run. This required a slight change in the macro generator, to bring flexibility to use it with different macros.
It was verified that this PR