Fix creator process for stopped annihilation#490
Merged
SeverinDiederichs merged 3 commits intoapt-sim:masterfrom Feb 20, 2026
Merged
Fix creator process for stopped annihilation#490SeverinDiederichs merged 3 commits intoapt-sim:masterfrom
SeverinDiederichs merged 3 commits intoapt-sim:masterfrom
Conversation
|
Can one of the admins verify this patch? |
SeverinDiederichs
force-pushed
the
fix_creator_process
branch
from
28f3544 to
b3161cb
Compare
JuanGonzalezCaminero
approved these changes
Feb 20, 2026
Contributor
JuanGonzalezCaminero
left a comment
JuanGonzalezCaminero
left a comment
There was a problem hiding this comment.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the creator process was always set to be the step limiting process of the parent. However, this is not true for positrons that are stopped due to continuous energy loss:
The emerging gammas should have the creator process of stopped annihilation, not MSC. Therefore, both variables are separated and the creator process is set properly.
It was verified that this PR