Skip to content

Conversation

@yagreut
Copy link
Contributor

@yagreut yagreut commented Nov 26, 2025

Add Azure Network checks AVD-AZU-0073 - AVD-AZU-0076

@yagreut yagreut requested a review from simar7 as a code owner November 26, 2025 11:44
@nikpivkin
Copy link
Contributor

nikpivkin commented Nov 26, 2025

I created a PR to fix an issue with the AVD-AZU-0066 check


import data.lib.cloud.metadata

networkinterfaces := input.azure.network.networkinterfaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input.azure.network.networkinterfaces is used only once, does it make sense to make it a variable?


import data.lib.cloud.metadata

networkinterfaces := input.azure.network.networkinterfaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto


import data.lib.cloud.metadata

flowlogs := input.azure.network.networkwatcherflowlogs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto


deny contains res if {
some flowlog in flowlogs
not flowlog.enabled.value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to use the helper function value.is_false, as the value may be unknown.

import data.lib.net

# Sensitive ports that should not be exposed to broad networks
sensitive_ports := {20, 21, 23, 25, 53, 110, 135, 139, 143, 161, 389, 636, 993, 995, 1433, 1521, 3306, 5432, 6379}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment to each port to understand which protocol or service uses them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants