Added a basic model for simulating the Greenland Attenuation Lengths.…#59
Added a basic model for simulating the Greenland Attenuation Lengths.…#59FlahertyJustinC wants to merge 2 commits intomasterfrom
Conversation
… User must set GREENLAND_ATTEN in their setup.txt, where 0 (default) just uses the current South Pole models, whereas 1 and 2 use the upper and lower limits of the Bogorodsky model in the RNO-G publication linked here: doi.org/10.1017/jog.2022.40. It simply replaces the South Pole attenuation lengths with the Greenland values.
|
Thanks Justin! Is there a reason this can't be handled by just changing |
|
Also, as this model looks frequency independent, I advise adding a check in Settings.cc to prevent the use of |
clark2668
left a comment
clark2668
left a comment
There was a problem hiding this comment.
This for the most part looks good. I asked a few questions above. Also, can you add a comment to log.txt?
| ifstream greenlandLower("data/greenland_attenlength_bogorodsky_lower.txt"); | ||
| if(greenlandLower.fail()) | ||
| {cerr << "Failed to open greenland_attenlength_bogorodsky_lower.txt"; | ||
| exit(1); |
There was a problem hiding this comment.
Does exit(1) correctly kill the program? That is, will it terminate all of AraSim? I prefer throw std::runtime_error, but it's a matter of taste. The important thing is that it stops AraSim.
2 participants
… User must set GREENLAND_ATTEN in their setup.txt, where 0 (default) just uses the current South Pole models, whereas 1 and 2 use the upper and lower limits of the Bogorodsky model in the RNO-G publication linked here: doi.org/10.1017/jog.2022.40. It simply replaces the South Pole attenuation lengths with the Greenland values.