fix(APP-3440): Fix NumberInput component to correctly update value on buttons click

[cgero-eth]

Description

• From version 7.6.0, the react-imask does not correctly trigger the onAccept callback on value change, see issue here => Fix: onAccept is never called uNmAnNeR/imaskjs#1045

Task: APP-3440

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• I ran all tests with success and extended them if necessary.
• I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
  the latest version.
• I have tested my code on the test network.

[shan8851]

@cgero-eth all changes look good and everything is working as expected.

However I wonder if we can slightly improve the UX. When we have min or max set we could disable the individual + or - button as right now it is clickable and nothing happens, so we should indicator somehow to the user that it is not possible by disabling buttons and/or having some type of label. My vote would just be to disable the buttons.

I don't think we should necessarily add this change to this PR though, seen as though right now input is not working properly the priority should be to get this fix merged, but perhaps one for the future. wdyt?

[cgero-eth]

@cgero-eth all changes look good and everything is working as expected.

However I wonder if we can slightly improve the UX. When we have min or max set we could disable the individual + or - button as right now it is clickable and nothing happens, so we should indicator somehow to the user that it is not possible by disabling buttons and/or having some type of label. My vote would just be to disable the buttons.

I don't think we should necessarily add this change to this PR though, seen as though right now input is not working properly the priority should be to get this fix merged, but perhaps one for the future. wdyt?

Good point, could you create a task in Jira so we can keep track of this suggestion?

[shan8851]

@cgero-eth all changes look good and everything is working as expected.
However I wonder if we can slightly improve the UX. When we have min or max set we could disable the individual + or - button as right now it is clickable and nothing happens, so we should indicator somehow to the user that it is not possible by disabling buttons and/or having some type of label. My vote would just be to disable the buttons.
I don't think we should necessarily add this change to this PR though, seen as though right now input is not working properly the priority should be to get this fix merged, but perhaps one for the future. wdyt?

Good point, could you create a task in Jira so we can keep track of this suggestion?

Done - APP-3499