Skip to content

Add nodejs support#7

Merged
bluepal-yaswanth-peravali merged 19 commits intomainfrom
add-nodejs-support
Apr 7, 2026
Merged

Add nodejs support#7
bluepal-yaswanth-peravali merged 19 commits intomainfrom
add-nodejs-support

Conversation

@bluepal-yaswanth-peravali
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the service maker on the included shoppinglist-express project and produced a project.tar.gz with it. Then I looked into this and found that the node_modules folder seems to contain all dependencies and not only those which are needed but are not contained in the base image.
I do not understand why this has happened?
It seems the mechanism to only install the additionally needed packages is not working.
Can you please investigate this?

@@ -0,0 +1,94 @@
#!/usr/bin/env node
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really have to do this "manually"? I had hoped that this rather complicated and potentially error-prone analysis would be done by some standard js packaging tool like npm (or whatever).
For the python case we could make use of uv for this.

Copy link
Copy Markdown
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's leave this for now as it is. We "manually" compute the dependency list. I had hoped that some tool like npm can do this for us, but if not, then we must do it ourselves.

@bluepal-yaswanth-peravali bluepal-yaswanth-peravali merged commit 5ec9192 into main Apr 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants