Add rounding to Baud Rate Divisor calculation. Permits operation at …#55
Open
WestfW wants to merge 2 commits intoarduino:masterfrom
Open
Add rounding to Baud Rate Divisor calculation. Permits operation at …#55WestfW wants to merge 2 commits intoarduino:masterfrom
WestfW wants to merge 2 commits intoarduino:masterfrom
Conversation
…30400. regression tested at standard speeds 9600, 19200, 38400, 57600, 115200...
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Baud Rate Generator Divisor calculations in UARTClass::init() do not round, leading to error rates higher than they could be. In particular, the error at 230400bps is both large and in the opposite direction of the 16u2 error, and it fails. Adding rounding allows it to work.
regression tested at standard speeds 9600, 19200, 38400, 57600, 115200...