Fan vibration monitoring UI #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matteo-it
force-pushed
the
Matteo-it/fan-vibration-monitoring
branch
from
d62f63e to
6f7f0e9
Compare
mcmchris
suggested changes
Nov 25, 2025
mcmchris
left a comment
mcmchris
left a comment
There was a problem hiding this comment.
@Matteo-it I tested the code (I know this is work in progress) but I noticed that the chart was not being cleared and was showing an overlapped messy line chart. With this addition, this is fixed 🙏
| canvas.width = currentWidth; | ||
| canvas.height = currentHeight; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| // Clear the canvas before drawing the new frame! | |
| ctx.clearRect(0, 0, currentWidth, currentHeight); |
There was a problem hiding this comment.
I tested the code (I know this is work in progress) but I noticed that the chart was not being cleared and was showing an overlapped messy line chart. With this addition, this is fixed 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fan vibration monitoring Update UI