Skip to content

Client timeout test now avoids internet access #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Client timeout test now avoids internet access #62

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe8539b
Client timeout test now avoids internet access
jmaslak Jan 26, 2025
7d6441e
Use defer to close socket in client timeout test
jmaslak Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ package goeapi

import (
"fmt"
"net"
"os"
"os/user"
"regexp"
Expand Down Expand Up @@ -460,8 +461,15 @@ func TestClientConnectInvalidTransport_UnitTest(t *testing.T) {
}

func TestClientConnectTimeout_UnitTest(t *testing.T) {
// 1.1.1.2 is assumed to be an unreachable bogus address
node, err := Connect("http", "1.1.1.2", "admin", "admin", 80)
// We create a local socket that never gives any responses
// We assume that 127.0.0.1 exists as the loopback on the test host.
sock, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Fatal("Error in test setup (listen).")
}
defer sock.Close()
port := sock.Addr().(*net.TCPAddr).Port
node, err := Connect("http", "127.0.0.1", "admin", "admin", port)
if err != nil {
t.Fatal("Error in connect.")
}
Expand Down