fix(json-schema): spread enums before passing into type.enumerated#1566
Merged
ssalbdivad merged 8 commits intoarktypeio:mainfrom Dec 21, 2025
Merged
fix(json-schema): spread enums before passing into type.enumerated#1566ssalbdivad merged 8 commits intoarktypeio:mainfrom
ssalbdivad merged 8 commits intoarktypeio:mainfrom
Conversation
Contributor
Author
ssalbdivad
approved these changes
Dec 21, 2025
Member
ssalbdivad
left a comment
There was a problem hiding this comment.
No worries on the git issues, I screw that stuff up constantly. Thanks!
ssalbdivad
pushed a commit
to shaungrady/arktype
that referenced
this pull request
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a bug in
json-schemain which JSON Schemas that containedtypeandenumincorrectly threw an error.Example JSON Schema:
Should pass and result in a
type('"PENDING" | "COMPLETE"'), but rather errored.The cause was passing the enum array as an array to
type.enumerated, rather than spreading it.This PR patches
parseCommonJsonSchemato spread the enum and adds a test case to verify the fix.mainbranchpnpm prCheckslocally