More accurate butter knife and dagger2 excludes#47
Open
angry-programmer wants to merge 1 commit intoarturdm:masterfrom
Open
More accurate butter knife and dagger2 excludes#47angry-programmer wants to merge 1 commit intoarturdm:masterfrom
angry-programmer wants to merge 1 commit intoarturdm:masterfrom
Conversation
simtel12
reviewed
Oct 1, 2018
| '**/*_*Factory*.*', | ||
| '**/*Component*.*', | ||
| '**/*Subcomponent*.*', | ||
| '**/*Module*.*'].asImmutable() |
Contributor
There was a problem hiding this comment.
These seem like common names that not only Dagger is using. I know that at my company, we have a fair number of *Module.java files that definitely need coverage. Component also seems uncommon, but not exclusive to Dagger.
Do you think it might be better to restrict these excludes to the buildDir/generated directory?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.