Refactor to support new diagnostics #62
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
===========================================
- Coverage 97.44% 78.07% -19.38%
===========================================
Files 6 8 +2
Lines 274 342 +68
===========================================
Hits 267 267
- Misses 7 75 +68 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+18
to
+20
| - if ``0.5 < \\hat{k} \\lessim 0.7, then the variance is infinite and plain IS can behave | ||
| poorly. PSIS works well in this regime, but the convergence rate is between ``S^{−1/2}`` | ||
| and ``S^{−3/10}``. |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| - if ``0.5 < \\hat{k} \\lessim 0.7, then the variance is infinite and plain IS can behave | |
| poorly. PSIS works well in this regime, but the convergence rate is between ``S^{−1/2}`` | |
| and ``S^{−3/10}``. | |
| - if ``0.5 < \\hat{k} \\lessim 0.7, then the variance is infinite and plain IS can behave poorly. PSIS works well in this regime, but the convergence rate is between``S^{−1/2}``and``S^{−3/10}``. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of the PSIS paper added new diagnostics in addition to the Pareto shape diagnostic. The new diagnostics are detailed in stan-dev/posterior#237.
This PR adds these diagnostics. It additionally will completely refactor the codebase to separate diagnosing from smoothing. In particular, it adds
pareto_diagnoseandpareto_smooth. The former simply computes all diagnostics for the specified tails, while the latter both computes diagnostics for the tails but also smooths them.Fixes #26. Relates #21.