Remove old logs #1150
Open
Remove old logs #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you change the log filename pattern, asbru will stop deleting the log files. It relies to much on the original pattern, it uses the pattern date to guess how old is the file, etc.
Changed the algorithm to use the modified time instead to delete the oldest. Still has a problem, if a user removes the uuid from the pattern wont be able to delete any old files. So we should consider making the uuid mandatory if the user removes it, warn that can not be saved as a pattern. Besides if removed could lead to several different sessions log to the same file and then the log is a mixture of logs from different places.
Introduced a new Library, but is supposed to be a Standard Library so it should not affect including it.
Final point, with this fix log files are removed as expected, when the max amount is reached.