Retain cache hits in memory when loaded from disk#110
Open
gravey wants to merge 1 commit intoaschuch:masterfrom
Open
Retain cache hits in memory when loaded from disk#110gravey wants to merge 1 commit intoaschuch:masterfrom
gravey wants to merge 1 commit intoaschuch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if the in-memory cache is purged and on-disk cached items remain, when an item is requested from the cache, it is loaded from disk each time it's requested. This is a fix that simply places items back into the in-memory cache when they're loaded from disk.
A test has been added.
Open to other suggestions.