-
Notifications
You must be signed in to change notification settings - Fork 240
Add hosted cobalt crank profiles and runs #2105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5d07b2c
to
f4e2976
Compare
f4e2976
to
416b39b
Compare
Does hosted mean these are the machines that are VMs that we have created on our physical hardware? |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… the conventions in the azure linux 3 update PR, and added the benchmarks_ci_cobalt.json file to include the cobalt machines and to match the tests of the Azure Linux VMs ci.
…s updated the cobalt machines to only use 1 queue for now.
…e AL3 machines. Generated the pipeline yaml file for the cobalt hosted machines.
c1e120d
to
d14a7f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add hosted cobalt crank profiles and runs. This includes adding the cobalt hosted machine setups to the ci.setup.yml, aspnet.profile.yml, and aspnet.standard.profile.yml files, adding the hosted cobalt ci configuration file, and adding the hosted cobalt ci run itself.
If we think including these with the already running benchmarks_ci runs makes more sense, we can do that. I will just be interested in ideas on what we think a good practice will be for ensuring the local vnet machine tests don't try to use the cobalt machines.
This also brings back testing for the ARM (80 and 26 core) scenarios removed here:
#2099
A new pipeline will need to be created to run these.