feat: auto detect globs #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 09130bf in 39 seconds
More details
- Looked at
302lines of code in9files - Skipped
1files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. src/extension/common.ts:43
- Draft comment:
Ensureworkspace.workspaceFoldersis defined before accessinguris[0]to prevent potential errors when there are no workspace folders. - Reason this comment was not posted:
Comment did not seem useful.
2. src/webview/hooks/useQuery.tsx:73
- Draft comment:
Consider cleaning up thechildPort.onMessagelistener inuseEffectto prevent potential memory leaks when the component is unmounted. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_2Mf3wb6D4k2e70MP
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
Author
|
Headless test is failed, anything I missed? @HerringtonDarkholme |
alexzhang1030
force-pushed
the
feat/glob
branch
from
5ede730 to
f8a73da
Compare
Contributor
Author
|
I have rewritten the logic, now there is no auto-detect, we will force enable globs if the |
| const validIncludeFile = includeFile.split(',').filter(Boolean) | ||
| const hasGlobPattern = validIncludeFile.some(i => i.includes('*')) | ||
| if (hasGlobPattern) { | ||
| args.push(...validIncludeFile.map(i => `--globs=${i}`)) |
| <li> | ||
| If you're using glob patterns in the include file, please ensure | ||
| that your version of ast-grep is above | ||
| <code style={codeStyle}>v0.28.0</code>. |
Member
There was a problem hiding this comment.
this is good enough. thanks
HerringtonDarkholme
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now ast-grep vscode supports
globswhen binary version is abovev0.28.0.Important
Adds support for auto-detecting and using glob patterns in ast-grep VSCode extension when binary version is 0.28.0 or higher.
detectSgVersion()incommon.tsto determine the binary version.buildCommand()insearch.tsto include glob patterns if supported.IncludeFile.tsxto update placeholder text and handle glob input based on version.useDetectGlobFeatureAvailable()inuseFeature.tsxto check glob feature availability.useQuery.tsxanduseSearch.tsxto handle glob state in search queries.compare-versionstopackage.jsonfor version comparison.This description was created by
for 09130bf. It will automatically update as commits are pushed.