Fix prettier plugins collision (with the one in prettier config file) #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a collision between the prettier plugins provided by openapi-zod-client and the ones listed in the prettier config file. It would be possible to merge the lists instead, but using plugins not present in the openapi-zod-client node_modules may end up with compatibility problems. Note: the silent "try/catch" tends to hide bugs in this kind of situations. It just doesn't apply prettier.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
moranda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I encountered a problem with prettier not being applied even with the
--prettieroption. I found out that an error was thrown during parsing. The problem was that the typescript plugin was missing because the "plugins" argument of the Prettier.format() function was overridden by the "plugins" property of the options (coming from my .prettierrc file). It ended up with a weird error since prettiers fell back to the prettier installed in my base project which uses async in the parse process. The small addition I provide here should solve the bug and prevent incompatible plugins to be added through config file.It would be possible to merge the lists instead, but using plugins not present in the openapi-zod-client node_modules may end up with compatibility problems.
Thank you for your very handy package! Hope this PR will help.