Skip to content

Conversation

@Ethics03
Copy link

Pull Request

This PR has 2 changes, first improves the icon size and gap for windows/linux full titlebar,
the second PR increased the font size of file-tree title for better readability.

Description

  • The icon size of Sparkles and Settings icon are changed from 12 -> 13 and the gap increased from 0.5 -> 1 for

  • windows/linux full titlebar, looked cleaner and more accessible.

  • In the main-sidebar, text size of projectname changed from text-xs -> text-sm to highlight the directory better and

  • to compensate that increased the icon size of FolderOpen, FilePlus and FolderPlus.

@mehmetozguldev mehmetozguldev requested review from a team and mehmetozguldev October 24, 2025 20:16
@kovsu
Copy link
Member

kovsu commented Oct 25, 2025

@Ethics03 Hi, thank you for contributing. Can you put the screenshot here?

@Ethics03
Copy link
Author

Ethics03 commented Oct 25, 2025

sure!

image

The projectName along with file operations is more accessible and now compensates to the size of the icons of toolkit bar.
In the title-bar, Sparkles and Settings icon are given decent gap along with size increase.

@ninet33n19
Copy link
Contributor

can we get before screenshot if possible ☺️

@Ethics03
Copy link
Author

Ethics03 commented Oct 25, 2025

sure !

image

These were the original sizes, I thought that having the file operations a bit bigger along with project name would be better
as its justifying the space and scale.

@kovsu
Copy link
Member

kovsu commented Oct 25, 2025

Actually it doesn't make sense to me. @mehmetozguldev what's your opinion.

@abue-ammar
Copy link
Contributor

gotta test this in mac. because i have seen big difference between looks in mac and linux before

@devkokooo
Copy link
Member

We should probably make icon size a variable that can be adjusted somewhere, maybe at top of file for now

@Ethics03
Copy link
Author

Yes, personally as I am on Linux and windows/linux have the same implementation for the titlebar as I saw when maximized the icons were really small.
I think for the whole titlebar and the sidebar there can be 3 variables for icons each depending on what size needed yall can cycle through them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants