Skip to content

fix: workflow output path schedule mode #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+48 −1
Open

fix: workflow output path schedule mode #745

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e7faea8
fix: ensure consistent workflow output path for scheduled runs
drockparashar Sep 27, 2025
989bdd4
Merge branch 'atlanhq:main' into fix/workflow-output-path-schedule-mode
drockparashar Sep 30, 2025
0e76789
fix: ensure consistent workflow output path for scheduled runs
drockparashar Sep 30, 2025
d01931c
Merge branch 'fix/workflow-output-path-schedule-mode' of https://gith…
drockparashar Sep 30, 2025
c10ff41
test: add unit tests for build_output_path including empty workflow I…
drockparashar Sep 30, 2025
00bc161
Merge branch 'main' into fix/workflow-output-path-schedule-mode
drockparashar Oct 6, 2025
6f39e65
fix: use safe placeholder for empty workflow_id in build_output_path
drockparashar Oct 6, 2025
b257dcc
test: update build_output_path test to expect 'unknown-workflow' for …
drockparashar Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion application_sdk/activities/common/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from datetime import timedelta
from functools import wraps
from typing import Any, Awaitable, Callable, List, Optional, TypeVar, cast
import re

from temporalio import activity

Expand Down Expand Up @@ -71,9 +72,15 @@ def build_output_path() -> str:
>>> build_output_path()
"artifacts/apps/appName/workflows/wf-123/run-456"
"""
# Sanitize workflow_id to remove any schedule/timestamp suffix
raw_workflow_id = get_workflow_id()

# If workflow_id contains a timestamp (e.g., '-YYYY-MM-DDTHH:MM:SSZ'), remove it
sanitized_workflow_id = re.sub(r'-\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$', '', raw_workflow_id)
Copy link

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern is hardcoded and assumes a specific timestamp format. Consider defining this as a module-level constant with a descriptive name like SCHEDULE_TIMESTAMP_PATTERN to improve maintainability and make the pattern reusable.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex should be compiled once at module level for better performance, especially since this function may be called frequently. Use re.compile() to create a compiled pattern object.

Copilot uses AI. Check for mistakes.

return WORKFLOW_OUTPUT_PATH_TEMPLATE.format(
application_name=APPLICATION_NAME,
workflow_id=get_workflow_id(),
workflow_id=sanitized_workflow_id,
run_id=get_workflow_run_id(),
)

Expand Down
Loading