chore: colourize the logs only when LOG_LEVEL == "DEBUG" #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekagrawal-atlan
requested review from
AtMrun,
firecast and
inishchith
as code owners
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 75.5%) Detailed Coverage Report |
📦 Trivy Vulnerability Scan Results
Report Summary
Scan Result Details✅ No vulnerabilities found during the scan for |
📦 Trivy Secret Scan Results
Report Summary
Scan Result Details✅ No secrets found during the scan for |
|
🛠 Docs available at: https://k.atlan.dev/application-sdk/log-coloring-through-env |
Copilot finished reviewing on behalf of
abhishekagrawal-atlan
November 11, 2025 12:05
Collaborator
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/818 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the logging behavior to conditionally enable log colorization based on the LOG_LEVEL environment variable. Colorization is now only enabled when LOG_LEVEL is set to "DEBUG", while previously logs were always colorized.
Key Changes
- Added conditional logic to set the
colorizeparameter based on LOG_LEVEL - Colorization is enabled only for DEBUG level, disabled for all other log levels (INFO, WARNING, ERROR, etc.)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Abhishek Agrawal <[email protected]>
OnkarVO7
approved these changes
Nov 12, 2025
📦 Example workflows test results
|
📦 Example workflows test results
|
📦 Example workflows test results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Additional context (e.g. screenshots, logs, links)
Checklist
Copyleft License Compliance
Note
Use colored log format only when LOG_LEVEL is DEBUG; otherwise emit plain, non-colorized logs.
atlan_format_str_color) and plain (atlan_format_str_plain) formats and select based onLOG_LEVEL.colorize=Trueonly forDEBUG; use plain format andcolorize=Falsefor other levels.ACTIVITY,METRIC,TRACING) and sink setup unchanged.Written by Cursor Bugbot for commit d2ad324. This will update automatically on new commits. Configure here.