Skip to content

SEC-859 | Resolved Critical dependabot alerts #29 and #31 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SEC-859 | Resolved Critical dependabot alerts #29 and #31 #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5013b7b
Upgraded spark-core_2.12 to 3.3.3
dhanyavg-atlan May 20, 2025
16edad6
Upgraded calcite to 1.32.0
dhanyavg-atlan May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
<htrace.version>4.1.5</htrace.version>
<bigtable.version>1.24.0</bigtable.version>
<!-- align with org.apache.spark:spark-core_2.12 -->
<spark.version>3.3.3</spark.version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should you not bump the version of atlan-janusgraph @dhanyavg-atlan cc: @sumandas0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,
I think we should do that.

I think changing 1.1.0-SNAPSHOT to 1.1.1-SNAPSHOT or something similar.

But, in atlas-metastore we are using 0.6.03 version of janusgraph.

So, it will be unaffected if I make changes here right?

@sumandas0 @nikhilbonte21 Please give suggestions here what to do?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhanyavg-atlan , I think we do not need spark dependency in metastore, can we remove this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, please ignore last comment.

Dhanya is correct, we do not use master branch, no harm in pushing any change in master branch

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense @nikhilbonte21

But, if someone using 1.1.0-SNAPSHOT anywhere, if we don't update this,
there is a possibality that these new updates won't be in the version mentioned.

So, I am thinking of changing that to 1.1.1-SNAPSHOT or you can give a better name for the new version.

If I am changing, I should also make sure that it is updated in all the pom.xml files.

So, please suggest accordingly on what to do.

<jackson2.version>2.16.0</jackson2.version>
<lucene-solr.version>8.11.2</lucene-solr.version>
<elasticsearch.version>8.10.4</elasticsearch.version>
Expand Down Expand Up @@ -120,6 +121,7 @@
<caffeine.version>2.9.3</caffeine.version>
<checker-qual.version>3.40.0</checker-qual.version>
<curator.version>5.5.0</curator.version>
<calcite.version>1.32.0</calcite.version>
</properties>
<modules>
<module>janusgraph-grpc</module>
Expand Down Expand Up @@ -509,6 +511,17 @@
</build>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.apache.calcite</groupId>
<artifactId>calcite-core</artifactId>
<version>${calcite.version}</version>
</dependency>
<!-- Override TinkerPop’s transitive Spark 3.3.2 -->
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-core_2.12</artifactId>
<version>${spark.version}</version>
</dependency>
<!-- Tinkerpop 3.x -->
<dependency>
<groupId>org.apache.tinkerpop</groupId>
Expand Down
Loading