Skip to content

Conversation

uday-atlan
Copy link
Contributor

@uday-atlan uday-atlan commented Sep 21, 2025

✨ Description

Add support for rule conditions and incremental for DQ rules

Linear:

Docs PR:


🧩 Type of change

Select all that apply:

  • 🚀 New feature (non-breaking change that adds functionality)
  • 🐛 Bug fix (non-breaking change that fixes an issue) — please include tests! Refer testing-toolkit 🧪
  • 🔄 Refactor (code change that neither fixes a bug nor adds a feature)
  • 🧹 Maintenance (chores, cleanup, minor improvements)
  • 💥 Breaking change (fix or feature that may break existing functionality)
  • 📦 Dependency upgrade/downgrade
  • 📚 Documentation updates

✅ How has this been tested? (e.g. screenshots, logs, workflow links)

  • Created and tested 3 new DQ rule types (String Length, Regex, Valid Values).
  • Verified the update working as expected for these new rule types
  • Verified the new set_dq_row_scope_filter_column method works correctly by updating the row scope filter.
  • Confirmed all rules appear properly in the UI.

📋 Checklist

  • My code follows the project’s style guidelines
  • I’ve performed a self-review of my code
  • I’ve added comments in tricky or complex areas
  • I’ve updated the documentation as needed
  • There are no new warnings from my changes
  • I’ve added tests to cover my changes
  • All new and existing tests pass locally

@uday-atlan uday-atlan marked this pull request as ready for review September 21, 2025 18:44
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - few minor requested changes below:

Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @uday-atlan 🚀

@Aryamanz29 Aryamanz29 merged commit a742ad6 into main Sep 23, 2025
110 of 113 checks passed
@Aryamanz29 Aryamanz29 deleted the DQ-164 branch September 23, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants