Skip to content

Conversation

nikhilbonte21
Copy link

Change description

Description here

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Helm Config Changes for Running Tests (Staging PR)

Does this PR require Helm config changes for testing?

  • Tests are NOT required for this commit. (You can proceed with the PR.) ✅
  • No, Helm config changes are not needed. (You can proceed with the PR.) ✅
  • Yes, I have already updated the config-values on enpla9up36. (You can proceed with the PR.) ✅
  • Yes, but I have NOT updated the config-values. (Please update them before proceeding; or, tests will run with default values.)⚠️

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

cursor[bot]

This comment was marked as outdated.

LOG.error("CRITICAL: RedisServiceImpl initialization FAILED", e);
MetricUtils.recordRedisConnectionFailure();
throw new AtlasException("Error creating Sentinel redis client.", e);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Redis Connection Retry Loop Causes Startup Block

The init() method's new retry loop can indefinitely block application startup if Redis is unavailable, as it lacks a retry limit. The null check for redisClient and redisCacheClient is unreachable because Redisson.create() throws an exception on failure. Also, calling MetricUtils.recordRedisConnectionFailure() during this early startup phase may cause exceptions or fail to record metrics if the system isn't initialized.

Fix in Cursor Fix in Web

@krsoninikhil krsoninikhil merged commit 4ddbf63 into beta Sep 8, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants