MLH-1199 remove prometheus metrics in startup (suspect this for rollo…

[sriram-atlan]

Change description

remove prometheus metrics in startup (suspect this for rollout failures

Type of change

• Bug fix (fixes an issue)
• New feature (adds functionality)

Related issues

Fix #1

Helm Config Changes for Running Tests (Staging PR)

Does this PR require Helm config changes for testing?

• Tests are NOT required for this commit. (You can proceed with the PR.) ✅
• No, Helm config changes are not needed. (You can proceed with the PR.) ✅
• Yes, I have already updated the config-values on enpla9up36. (You can proceed with the PR.) ✅
• Yes, but I have NOT updated the config-values. (Please update them before proceeding; or, tests will run with default values.)⚠️

Checklists

Development

• Lint rules pass locally
• Application changes have been tested thoroughly
• Automated tests covering modified code pass

Security

• Security impact of change has been considered
• Code follows company security practices and guidelines

Code review

• Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
• "Ready for review" label attached and reviewers assigned
• Changes have been reviewed by at least one other contributor
• Pull request linked to task tracker where applicable

[cursor]

Bug: Redis Test Fails in No-Redis Configurations

Removing the NoRedisServiceImpl check in validateDependencies() causes the Redis connectivity test to run against the no-op implementation. This fails because getValue() returns null, leading to a "Redis connectivity test failed - value mismatch" exception and preventing FeatureFlagStore initialization in no-Redis configurations.

common/src/main/java/org/apache/atlas/service/FeatureFlagStore.java#L95-L107

atlas-metastore/common/src/main/java/org/apache/atlas/service/FeatureFlagStore.java

Lines 95 to 107 in 8357e7c

	private void validateDependencies() {
	LOG.info("Validating FeatureFlagStore dependencies...");
	try {
	// Test Redis connectivity with a simple operation
	String testKey = "ff:_health_check";
	redisService.putValue(testKey, "test");
	String testValue = redisService.getValue(testKey);
	redisService.removeValue(testKey);
	if (!"test".equals(testValue)) {
	throw new RuntimeException("Redis connectivity test failed - value mismatch");
	}

 

---

[cursor]

Bug: Spring Bean Naming Issue Affects Dependency Injection

Removing the explicit redisServiceImpl bean name from the @Component annotation in NoRedisServiceImpl and RedisServiceLocalImpl causes Spring dependency injection to fail. FeatureFlagStore relies on @DependsOn("redisServiceImpl"), but no bean with that name is now registered.

Additional Locations (1)

• common/src/main/java/org/apache/atlas/service/redis/RedisServiceLocalImpl.java#L11-L12