Sync beta with master #5401
Sync beta with master #5401
Conversation
…tency Mlh 1240 custom metadata consistency
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| public String getValue(String key, String defaultValue) { | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
Bug: Redis Value Retrieval Ignores Default
The getValue(String key, String defaultValue) method in RedisServiceLocalImpl always returns null. This ignores the defaultValue parameter and violates the method's contract to provide a default when the key is not found or its value is empty, which can lead to NumberFormatException in callers.
| int counter = 0; | ||
|
|
||
| while (currentSize != expectedFieldKeys && counter++ < totalIterationsAllowed) { | ||
| while (currentSize < expectedFieldKeys && counter++ < totalIterationsAllowed) { |
There was a problem hiding this comment.
Bug: Cache Refresh Timing and Loop Condition Issues
The type-def cache refresh now waits for 2.5 seconds instead of the intended 5 seconds due to totalIterationsAllowed being hardcoded to 5, which can cause premature timeouts. Additionally, the loop condition changed from currentSize != expectedFieldKeys to currentSize < expectedFieldKeys, potentially causing early exits if the field key count temporarily exceeds the expected value.
2 participants
Change description
Type of change
Related issues
Helm Config Changes for Running Tests (Staging PR)
Does this PR require Helm config changes for testing?
enpla9up36. (You can proceed with the PR.) ✅Checklists
Development
Security
Code review