forked from apache/atlas
-
Notifications
You must be signed in to change notification settings - Fork 9
Staging helper #5406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Staging helper #5406
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f070e24
MLH-1240 improve refresh logic, reduce retry count and wait time
sriram-atlan 3a6b41a
MLH-1240 use version number to decide to invoke typedef cache refresh…
sriram-atlan 41df3cd
MLH-1240 reload only business metadata
sriram-atlan 7c3e04e
MLH-1240 increment internal cache version
sriram-atlan 248ea12
MLH-1240 reload business and classification typedef
sriram-atlan 28e84d9
MLH-1240 use consistent version and reload if necessary in all typede…
sriram-atlan 1a6c6f0
MLH-1240 update cache when current version is less than redis version
sriram-atlan 887ddc6
MLH-1240 refresh custom types always (wip testing)
sriram-atlan b42fdbf
MLH-1240 refresh enum and always read from transient registry
sriram-atlan cb8c0ab
MLH-1240 track version for all custom types to load them independently
sriram-atlan b91db52
MLH-1240 commit update
sriram-atlan ce513e4
MLH-1240 clear that type of atlas typedef and reload to handle delete…
sriram-atlan 0cf1155
MLH-1240 add struct, enum and relationship def and refactor cache ref…
sriram-atlan 7e06e58
Merge pull request #5380 from atlanhq/mlh-1240-custom-metadata-consis…
sriram-atlan 34f72fe
remove other redis implementations
sriram-atlan aff2023
Merge pull request #5400 from atlanhq/fix-redis-wiring
sriram-atlan 16da29d
MLH-1277 fix for delete tags correctly
sriram-atlan bf37bc7
MLH-1277 branch to build
sriram-atlan adff2bb
Merge pull request #5403 from atlanhq/1277-master
sriram-atlan 3e6c3c9
Merge branch 'master' into staging-helper
nikhilbonte21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 0 additions & 52 deletions
52
common/src/main/java/org/apache/atlas/service/redis/NoRedisServiceImpl.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 0 additions & 44 deletions
44
common/src/main/java/org/apache/atlas/service/redis/RedisServiceLocalImpl.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Method Fails Safe Fallback, Causes Duplicate Metrics
The
getValue(key, defaultValue)
method re-throws exceptions instead of returning thedefaultValue
when an error occurs, defeating its purpose as a safe fallback. This also leads to duplicated metric recording and error logging, as the innergetValue(key)
call already handles these.