ignore deleting core types. log errors when it happens #5407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ttr.addTypes(businessMetadataDefs); | ||
| commitUpdates = true; | ||
| } catch (Throwable abe) { | ||
| LOG.warn("reloadBusinessMetadataTypeDefs(): failed to reload BM defs", abe); |
There was a problem hiding this comment.
Bug: Metadata Reload Inconsistencies and Exception Handling
Two inconsistencies appear in the reload*TypeDefs methods:
reloadBusinessMetadataTypeDefs()andreloadClassificationMetadataTypeDefs()are missing theatlas_coreservice type check, allowing built-in types to be removed during reload, unlike other type definitions.- All
reload*TypeDefsmethods now catch and logThrowable, effectively swallowing exceptions and breaking the API contract that declaresthrows AtlasBaseException.
Additional Locations (1)
| ttr.addTypes(enumDefs); | ||
| commitUpdates = true; | ||
| } catch (Throwable abe) { | ||
| LOG.warn("reloadEnumTypeDefs(): failed to reload enum defs", abe); |
There was a problem hiding this comment.
Bug: API Contract Violation in Exception Handling
The reload*TypeDefs methods now catch all Throwable exceptions and log them as warnings without rethrowing. This breaks the API contract, as these methods are declared to throw AtlasBaseException, masking critical errors and potentially leaving type definitions in a stale state.
Additional Locations (4)
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java#L172-L174repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java#L200-L202repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java#L228-L230repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java#L276-L278
| } | ||
| ttr.addTypes(classificationDefs); | ||
| commitUpdates = true; | ||
| } catch (Throwable abe) { |
There was a problem hiding this comment.
Bug: Classification Metadata Reload Fails Core Type Check
The reloadClassificationMetadataTypeDefs() method is missing the atlas_core service type check. This allows built-in classification types to be removed during reload operations, which is inconsistent with other reload*TypeDefs methods that now protect their core types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Type of change
Related issues
Helm Config Changes for Running Tests (Staging PR)
Does this PR require Helm config changes for testing?
enpla9up36. (You can proceed with the PR.) ✅Checklists
Development
Security
Code review