Skip to content

ADMIN-358 | Fix not_in operator tags in abac #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

ADMIN-358 | Fix not_in operator tags in abac #5426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions repository/src/main/java/org/apache/atlas/authorizer/JsonToElasticsearchQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,10 @@ public static JsonNode createQueryWithOperatorForTag(String operator, String att
return createDSLForTagKeyValue(attributeName, attributeValueNode);
}
}
case POLICY_FILTER_CRITERIA_NOT_EQUALS -> {
case POLICY_FILTER_CRITERIA_NOT_EQUALS, POLICY_FILTER_CRITERIA_NOT_IN -> {
ObjectNode mustNotNode = queryNode.putObject("bool").putObject("must_not");
if (attributeValueNode.isArray()) {
ArrayNode shouldArray = mustNotNode.putArray("should");
ArrayNode shouldArray = mustNotNode.putObject("bool").putArray("should");
for (JsonNode valueNode : attributeValueNode) {
shouldArray.add(createDSLForTagKeyValue(attributeName, valueNode));
}
Expand All @@ -197,17 +197,6 @@ public static JsonNode createQueryWithOperatorForTag(String operator, String att
shouldArray.add(createDSLForTagKeyValue(attributeName, attributeValueNode));
}
}
case POLICY_FILTER_CRITERIA_NOT_IN -> {
ObjectNode notInMustNot = queryNode.putObject("bool").putObject("must_not");
ArrayNode notInShouldArray = notInMustNot.putArray("should");
if (attributeValueNode.isArray()) {
for (JsonNode valueNode : attributeValueNode) {
notInShouldArray.add(createDSLForTagKeyValue(attributeName, valueNode));
}
} else {
notInShouldArray.add(createDSLForTagKeyValue(attributeName, attributeValueNode));
}
}
default -> LOG.warn("Found unknown operator {}", operator);
}
return queryNode;
Expand Down
Loading