MLH-1336 Sets tags FF true for all new tenants by default #5451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muniatl
reviewed
Sep 29, 2025
| } | ||
|
|
||
| } catch (Exception e) { | ||
| LOG.error("Error during auto-enable check for Tags v2 optimization", e); |
There was a problem hiding this comment.
When an exception occurs, do we abort the start? We shouldn't switch to v1 in case of exception
Collaborator
Author
There was a problem hiding this comment.
Yes, the exception is thrown. We don't switch to v1.
suraj5077
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
repository/src/main/java/org/apache/atlas/services/TagsV2AutoEnabler.java
Outdated
Show resolved
Hide resolved
nikhilbonte21
approved these changes
Oct 3, 2025
nikhilbonte21
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets Tags FF to true for all newly onboarded tenants or tenants where no tag type defs are present.
Goal is to avoid migration for any newly onboarded tenants.
Jira: https://atlanhq.atlassian.net/browse/MLH-1336
Note
Adds a startup component that enables the Tags V2 feature flag when no classification types exist.
org.apache.atlas.services.TagsV2AutoEnabler(repository/src/main/java/org/apache/atlas/services/TagsV2AutoEnabler.java):FeatureFlagStore.isTagV2Enabled()and graph forTRAITclassification types.ENABLE_JANUS_OPTIMISATIONflag totrueto enable Tags V2 by default.AtlasGraphquery for type-system vertices and logs outcomes; wraps errors inAtlasBaseException.Written by Cursor Bugbot for commit d9074a5. This will update automatically on new commits. Configure here.