Skip to content

Conversation

PRATHAM2002-DS
Copy link

@PRATHAM2002-DS PRATHAM2002-DS commented Oct 8, 2025

Change description

Description here

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Helm Config Changes for Running Tests (Staging PR)

Does this PR require Helm config changes for testing?

  • Tests are NOT required for this commit. (You can proceed with the PR.) ✅
  • No, Helm config changes are not needed. (You can proceed with the PR.) ✅
  • Yes, I have already updated the config-values on enpla9up36. (You can proceed with the PR.) ✅
  • Yes, but I have NOT updated the config-values. (Please update them before proceeding; or, tests will run with default values.)⚠️

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Note

Renames the repair type and updates the strategy to validate output port GUIDs using AtlasGraph, rewriting the attribute only when invalid GUIDs exist, and wires the factory accordingly.

  • Repair Strategy (RemoveInvalidGuidsRepairStrategy):
    • Change REPAIR_TYPE to REMOVE_INVALID_OUTPUT_PORT_GUIDS and constructor to accept AtlasGraph.
    • Validate GUIDs via AtlasGraphUtilsV2.findByGuid(graph) instead of EntityGraphRetriever.
    • Repair logic: collect valid/invalid GUIDs; rewrite OUTPUT_PORT_GUIDS_ATTR only if invalids are found; improved logging and error message.
  • Factory (RepairAttributeFactory):
    • Inject/store AtlasGraph; update supported type to REMOVE_INVALID_OUTPUT_PORT_GUIDS.
    • Pass AtlasGraph to strategy; update isValidRepairType and error text.

Written by Cursor Bugbot for commit 3a75a92. This will update automatically on new commits. Configure here.

@PRATHAM2002-DS PRATHAM2002-DS merged commit 7982778 into beta Oct 8, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant