Skip to content

Conversation

@nikhilbonte21
Copy link

@nikhilbonte21 nikhilbonte21 commented Oct 8, 2025

Note

Introduces auto-enable for Tags V2 on new instances without classification types, refines datamesh product update rules, hardens policy-delta/audit logging, adjusts soft-ref check, updates CI branches, and changes policy cache path.

  • Services:
    • Tags V2 Auto-enable: Add repository/src/main/java/org/apache/atlas/services/TagsV2AutoEnabler.java to enable Tags V2 when no classification types exist.
  • Datamesh:
    • Update Rules: In DataProductPreProcessor, allow updates on daapLineageStatus during archived state; otherwise still block non-restore edits.
  • Policy Delta:
    • Null-safety: In CachePolicyTransformerImpl, skip events with unmapped audit actions and guard deletes when deltaChangeType is null.
  • Auditing:
    • Extra MDC Field: In Log4JAuditDestination, add/remove enforcer (event.getAclEnforcer()) to MDC.
  • Model:
    • Soft Reference Check: In AtlasStructDef.AtlasAttributeDef.isSoftReferenced(), use case-insensitive "true" comparison.
  • Config:
    • Policy Cache Path: Update atlas-atlas-security.xml cache dir from /etc/atlas/atlasdev/policycache to /tmp/atlasdev/policycache.
  • CI/CD:
    • Workflow Branches: Add atlas_ci_cd_updates to chart-release-dispatcher; replace revert-custom-metadata-changes with fix-pg-prod-cm-soft-ref in maven.yml.

Written by Cursor Bugbot for commit d252e41. This will update automatically on new commits. Configure here.

}

if (!isBeingRestored) {
if (!isBeingRestored && !entity.hasAttribute(DAAP_LINEAGE_STATUS_ATTR)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Archived DataProduct Update Bypass

The condition !entity.hasAttribute(DAAP_LINEAGE_STATUS_ATTR) allows updates to archived DataProducts whenever DAAP_LINEAGE_STATUS_ATTR is present in the request. This bypasses the intended restriction to only allow DAAP_LINEAGE_STATUS_ATTR updates (or restoration), permitting other attributes to be modified on archived products.

Fix in Cursor Fix in Web

@nikhilbonte21 nikhilbonte21 merged commit 6251ebf into staging Oct 9, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants