Skip to content

Conversation

@krsoninikhil
Copy link

@krsoninikhil krsoninikhil commented Oct 8, 2025

Change description

Add logs to verify is vertex fetch is required

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Helm Config Changes for Running Tests (Staging PR)

Does this PR require Helm config changes for testing?

  • Tests are NOT required for this commit. (You can proceed with the PR.) ✅
  • No, Helm config changes are not needed. (You can proceed with the PR.) ✅
  • Yes, I have already updated the config-values on enpla9up36. (You can proceed with the PR.) ✅
  • Yes, but I have NOT updated the config-values. (Please update them before proceeding; or, tests will run with default values.)⚠️

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Note

Skips fetching the entity vertex during ABAC evaluation, adds concise attribute presence logs, and conditionally logs vertex-derived values using CollectionUtils.

  • Authorizer (ABAC evaluation):
    • Skip fetching AtlasVertex (set vertex = null) in evaluateABACPoliciesInMemory.
    • Add info log of entity attributes present (qn and attribute keys).
  • Attribute retrieval:
    • Adjust log messages to reference qn instead of entityId.
    • Log vertex-derived values only when non-empty, using CollectionUtils.isNotEmpty.
  • Imports:
    • Add org.apache.commons.collections.CollectionUtils.

Written by Cursor Bugbot for commit ed53fa7. This will update automatically on new commits. Configure here.

@krsoninikhil krsoninikhil merged commit 8b224ac into beta Oct 8, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant